ui: upgrade ember composable helper #13394
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade ember-composable-helpers to version 5.x. This version contains the
pick
-helper which makes composition in the template layer easier with Octane.Version 5.x also fixes a regression with
sort-by
that according to @johncowen was the reason why the version was pinned to4.0.0
at the moment.Version 5 of
ember-composable-helpers
removes thecontains
-helper in favor ofincludes
which I changed all occurences for.Testing & Reproduction steps
Tests are passing locally.
Links
Fix for slow sort-by - PR