Add TLS support in Envoy Prometheus endpoint #13481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
theme/cli
kyhavlov
requested review from
a team,
dhiaayachi and
ndhanushkodi
and removed request for
a team
2 tasks
|
@kyhavlov Will this be back ported to 1.12.x? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for enabling TLS on the Envoy Prometheus endpoint (enabled when
envoy_prometheus_bind_addris set) via new CLI flags for the CA/cert/key. The intention is to provide these in kubernetes via a mounted volume and have Envoy watch the files to dynamically reload the certs when the volume is updated.PR Checklist
external facing docs updated(separate PR)