Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker health check with docker 1.10 #1706

Closed
gdiazlo opened this issue Feb 9, 2016 · 4 comments
Closed

Docker health check with docker 1.10 #1706

gdiazlo opened this issue Feb 9, 2016 · 4 comments
Assignees
Labels
type/bug Feature does not function as expected

Comments

@gdiazlo
Copy link

gdiazlo commented Feb 9, 2016

Hello

Checks with docker 1.10 doesn't work using consul 0.6.3 from releases.hashicorp.com.

I think the current consul release has a version of go-dockerclient which has this issue:

fsouza/go-dockerclient#455

In consul/command/agent/check.go line 621, when calling c.dockerClient.StartExec, it fails with the error:

"Unable to start Exec: Unrecognized Input header" that seems to come from the go-dockerclient.

I guess recompiling the consul binary again will use the newest go-dockerclient, fixing the issue, but i haven't tested it.

@slackpad slackpad added the type/bug Feature does not function as expected label Feb 9, 2016
@slackpad slackpad self-assigned this Feb 9, 2016
@slackpad
Copy link
Contributor

slackpad commented Feb 9, 2016

Hi @gdiazlo thanks for opening an issue. I noticed this too during some local testing so I've got a test environment that does it and will see if the newer library version fixes the issue.

@sweco-seponr
Copy link

status on this?

@gdiazlo
Copy link
Author

gdiazlo commented Mar 7, 2016

We recompiled consul 0.6.3 with a new version of the go-dockerclient to fix this. I guess in the next release will be fixed. Not sure if the contributors plan to recompile current versions with the newest go-dockerclient.

@slackpad
Copy link
Contributor

slackpad commented Mar 9, 2016

Confirmed the latest client fixes this so teeing up a change to pull that in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Feature does not function as expected
Projects
None yet
Development

No branches or pull requests

3 participants