Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why? service deny policy in ACL rule of anonymous ineffective #2816

Closed
bomee opened this issue Mar 23, 2017 · 3 comments · Fixed by #2829
Closed

why? service deny policy in ACL rule of anonymous ineffective #2816

bomee opened this issue Mar 23, 2017 · 3 comments · Fixed by #2829
Milestone

Comments

@bomee
Copy link

bomee commented Mar 23, 2017

server and client both are 0.7.5

service "" {
  policy="deny"
}

curl http://host:8500/v1/catalog/services?token=anonymous
anonymous user still view all services info, isn't not safety?

@slackpad
Copy link
Contributor

Hi - we'd need more details about your configuration to figure out what's going on.

@bomee
Copy link
Author

bomee commented Mar 23, 2017

I have read source code find

func (f *aclFilter) allowService(service string) bool {
	if service == "" || service == ConsulServiceID {
		return true
	}
	return f.acl.ServiceRead(service)
}

a magic code service == ConsulServiceID.What is the intention of this code?

@slackpad
Copy link
Contributor

The Consul servers do the registration for that server on behalf of the cluster, so it was excluded from ACLs. That exception should be removed when enforceVersion8 is set, though, so I'll remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants