Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

agent/agent.go endpointsLock never uses the RLock/RUnlock #3376

Closed
tqh opened this issue Aug 9, 2017 · 2 comments
Closed

agent/agent.go endpointsLock never uses the RLock/RUnlock #3376

tqh opened this issue Aug 9, 2017 · 2 comments

Comments

@tqh
Copy link

tqh commented Aug 9, 2017

Should this be a RLock()/RUnlock instead?

consul/agent/agent.go

Line 959 in 8119497

a.endpointsLock.Lock()

@sean-
Copy link
Contributor

sean- commented Aug 9, 2017

Yes.

CC @magiconair

slackpad added a commit that referenced this issue Aug 10, 2017
@slackpad
Switches to using a read lock for the agent's RPC dispatcher.
f51d56c 
This prevents RPC calls from getting serialized in this spot.

Fixes #3376
@slackpad slackpad mentioned this issue Aug 10, 2017
Merged
@slackpad
Copy link
Contributor

@tqh great catch - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sean- @tqh @slackpad