-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consul agent ignoring -client
flag
#3397
Comments
I'll have a look |
Hmm, I can't reproduce this or I don't understand your setup. I did this:
What am I missing? |
I have |
I found the issue, I was missing |
I'll have a look. Will touch that code soon anyway. Glad you've found it. |
The `consul agent` command was ignoring extra command line arguments which can lead to confusion when the user has for example forgotten to add a dash in front of an argument or is not using an `=` when setting boolean flags to `true`. `-bootstrap true` is not the same as `-bootstrap=true`, for example. Since all command line flags are known and we don't expect unparsed arguments we can return an error. However, this may make it slightly more difficult in the future if we ever wanted to have these kinds of arguments. Fixes #3397
The `consul agent` command was ignoring extra command line arguments which can lead to confusion when the user has for example forgotten to add a dash in front of an argument or is not using an `=` when setting boolean flags to `true`. `-bootstrap true` is not the same as `-bootstrap=true`, for example. Since all command line flags are known and we don't expect unparsed arguments we can return an error. However, this may make it slightly more difficult in the future if we ever wanted to have these kinds of arguments. Fixes #3397
The `consul agent` command was ignoring extra command line arguments which can lead to confusion when the user has for example forgotten to add a dash in front of an argument or is not using an `=` when setting boolean flags to `true`. `-bootstrap true` is not the same as `-bootstrap=true`, for example. Since all command line flags are known and we don't expect unparsed arguments we can return an error. However, this may make it slightly more difficult in the future if we ever wanted to have these kinds of arguments. Fixes #3397
…lags The `consul agent` command was ignoring extra command line arguments which can lead to confusion when the user has for example forgotten to add a dash in front of an argument or is not using an `=` when setting boolean flags to `true`. `-bootstrap true` is not the same as `-bootstrap=true`, for example. Since all command line flags are known and we don't expect unparsed arguments we can return an error. However, this may make it slightly more difficult in the future if we ever wanted to have these kinds of arguments. Fixes #3397
consul version
for both Client and ServerClient:
0.9.0
Server:
0.9.0
consul info
for both Client and ServerClient:
Server:
Operating system and Environment details
RHEL 7
Description of the Issue (and unexpected/desired result)
When passing the
-client=10.0.3.11
flag and specifyingclient_addr: "10.0.3.11"
in the config file, it is still binding client to 127.0.0.1Reproduction steps
SCREEN consul agent -data-dir=/tmp/consul -node=agent-two -bind=10.0.3.11 enable-script-checks=true -config-dir=/etc/consul.d -client=10.0.3.11
The text was updated successfully, but these errors were encountered: