Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Raft protocol for operator raft list-peers into endpoint, make aware of address mapping #3449

Closed
slackpad opened this issue Sep 6, 2017 · 0 comments · Fixed by #3499
Labels
theme/operator-usability Replaces UX. Anything related to making things easier for the practitioner type/enhancement Proposed improvement or new feature
Milestone

Comments

@slackpad
Copy link
Contributor

slackpad commented Sep 6, 2017

Chasing down something for #1580 I noticed that the Raft protocol is looked up by node name (https://github.com/hashicorp/consul/blob/v0.9.3-rc1/command/operator_raft_list.go#L67-L77) while all the rest of the information is added internally by address (https://github.com/hashicorp/consul/blob/v0.9.3-rc1/agent/consul/operator_raft_endpoint.go#L36-L46).

It's not good that we index these in two ways, which could lead to confusion, and we can simplify this by adding the Raft protocol to the endpoint response and doing the mapping there. This also simplifies the ACL story for the endpoint since it doesn't need to do an extra call.

It would also be good to add some information to the endpoint and the CLI output to show when an address is being re-mapped. Might be good to have an extra column like Effective Address. Anything we can do to make it super clear what's going on is definitely worth it.

@slackpad slackpad added the type/enhancement Proposed improvement or new feature label Sep 6, 2017
@slackpad slackpad added this to the Next milestone Sep 6, 2017
@slackpad slackpad added the theme/operator-usability Replaces UX. Anything related to making things easier for the practitioner label Sep 8, 2017
preetapan added a commit that referenced this issue Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/operator-usability Replaces UX. Anything related to making things easier for the practitioner type/enhancement Proposed improvement or new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant