Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when DNS incompatible node name is used #3854

Closed
preetapan opened this issue Feb 2, 2018 · 1 comment
Closed

Warn when DNS incompatible node name is used #3854

preetapan opened this issue Feb 2, 2018 · 1 comment
Assignees
@mkeeler
Labels
good first issue A well-defined bug or improvement with sufficient context which should be approachable for new contr type/bug Feature does not function as expected
Milestone
Upcoming

Comments

@preetapan
Copy link
Contributor

preetapan commented Feb 2, 2018 •
edited
Loading

Consul accepts node names with dots in them, but they don't return as NS records because of compatibility checks against RFC1123.

More details in discussion thread in #3353.

We should log a warning about this similar to what we do during service registration
@preetapan preetapan added the type/bug Feature does not function as expected label Feb 2, 2018
@preetapan preetapan mentioned this issue Feb 2, 2018
Merged
@preetapan preetapan added this to the Next milestone Feb 5, 2018
@preetapan preetapan added the good first issue A well-defined bug or improvement with sufficient context which should be approachable for new contr label Mar 27, 2018
@mkeeler
Copy link
Member

mkeeler commented Mar 27, 2018

I am going to be taking a shot at fixing this and will assign it to myself once my Github account gets straightened out.

@mkeeler mkeeler self-assigned this Mar 27, 2018
mkeeler added a commit that referenced this issue Mar 27, 2018
@mkeeler
GH-3854: Warn when node name isnt a valid DNS label
3facce6
mkeeler referenced this issue Mar 29, 2018
@mkeeler
Merge pull request #3990 from hashicorp/b-gh-3854
ea6767d 
Warn when node name isnt a valid DNS label
@mkeeler mkeeler closed this as completed Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkeeler mkeeler

Labels
good first issue A well-defined bug or improvement with sufficient context which should be approachable for new contr type/bug Feature does not function as expected
Projects
None yet
Milestone
Upcoming
Development

No branches or pull requests
2 participants
@preetapan @mkeeler