tests: actually have TestSessionTTLRenew sleep during execution #5669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to an unintended order of operations issue with integer division TestSessionTTLRenew was sleeping for 0s every time. Also add explicit failures for when the various session requests return nil unexpectedly.
rboyer
commented
Apr 16, 2019
| @@ -397,14 +400,21 @@ func TestSessionTTLRenew(t *testing.T) { | |||
| } | |||
|
|
|||
| // Sleep to consume some time before renew | |||
| time.Sleep(ttl * (structs.SessionTTLMultiplier / 3)) | |||
| sleepFor := ttl * structs.SessionTTLMultiplier / 3 | |||
There was a problem hiding this comment.
Previously this worked out to be ttl * (2 / 3) => ttl * (0) => 0
freddygv
reviewed
Apr 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an unintended order of operations issue with integer division
TestSessionTTLRenew was sleeping for 0s every time.
Also add explicit failures for when the various session requests return
nil unexpectedly.