Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: actually have TestSessionTTLRenew sleep during execution #5669

Merged
merged 2 commits into from
Apr 17, 2019
Merged

tests: actually have TestSessionTTLRenew sleep during execution #5669

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2cdfe3
tests: actually have TestSessionTTLRenew sleep during execution
rboyer Apr 16, 2019
a78a2a2
remove useless checks
rboyer Apr 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion agent/session_endpoint_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,14 +397,21 @@ func TestSessionTTLRenew(t *testing.T) {
}

// Sleep to consume some time before renew
time.Sleep(ttl * (structs.SessionTTLMultiplier / 3))
sleepFor := ttl * structs.SessionTTLMultiplier / 3
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously this worked out to be ttl * (2 / 3) => ttl * (0) => 0

if sleepFor <= 0 {
t.Fatalf("timing tests need to sleep")
}
time.Sleep(sleepFor)

req, _ = http.NewRequest("PUT", "/v1/session/renew/"+id, nil)
resp = httptest.NewRecorder()
obj, err = a.srv.SessionRenew(resp, req)
if err != nil {
t.Fatalf("err: %v", err)
}
if obj == nil {
t.Fatalf("session '%s' expired before renewal", id)
}
respObj, ok = obj.(structs.Sessions)
if !ok {
t.Fatalf("should work")
Expand Down