Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate hostname in consul.runtime metric names to labels #9181

Open
mkcp opened this issue Nov 13, 2020 · 0 comments
Open

Migrate hostname in consul.runtime metric names to labels #9181

mkcp opened this issue Nov 13, 2020 · 0 comments
Labels
theme/telemetry Anything related to telemetry or observability

Comments

@mkcp
Copy link
Contributor

mkcp commented Nov 13, 2020

Feature Description

Consul's runtime metrics place the hostname in the middle of metric names. Typically these take the form of namespace.subsystem.measurement, so in a way these runtime metrics are making the namespace also include the hostname of the current system. Ideally, the host should be identified by a label so users can more easily perform aggregates to get answers like: find the highest sum of gc pauses across the cluster with max(). With the host in the name rather than the label, an operator of a modern metrics pipeline would have to update this query individually for every host that enters the cluster. In modern systems this information is now expected to come in from the scraping or receiving backend like Prometheus or Datadog, though we can still include a host label for compatibility with systems that don't support labels.

This would be a breaking change, so we ought to deprecate the previous behavior and double-emit. Then, if we can get this in within 1.9.x point releases, we can flag the old behavior behind {telemetry = { disable_compat_1.9 = true }}.

@mkcp mkcp added type/bug Feature does not function as expected theme/telemetry Anything related to telemetry or observability and removed type/bug Feature does not function as expected labels Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/telemetry Anything related to telemetry or observability
Projects
None yet
Development

No branches or pull requests

1 participant