Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log replication warnings when no error suppression is defined #9320

Merged
merged 2 commits into from Jan 8, 2021
Merged

Log replication warnings when no error suppression is defined #9320

merged 2 commits into from Jan 8, 2021

Conversation

crhino
Copy link
Contributor

@crhino crhino commented Dec 3, 2020

Previously this conditional accidentally skipped over all replicators that did not configure r. suppressErrorLog.

@crhino crhino requested a review from a team December 3, 2020 16:49
@crhino crhino mentioned this pull request Dec 3, 2020
Closed
hanshasselberg
hanshasselberg reviewed Dec 4, 2020
View reviewed changes
Copy link
Member

@hanshasselberg hanshasselberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment about the expression.

agent/consul/replication.go Outdated Show resolved Hide resolved
@woz5999 woz5999 mentioned this pull request Dec 31, 2020
Closed
@woz5999
Copy link
Contributor

woz5999 commented Dec 31, 2020

@crhino @i0rek i think this would also help with troubleshoot #9201
given how fragile the config replication seems to be at this point, it would be cool to get this merged.

@crhino crhino force-pushed the cpiraino/log-replication-warnings branch from 14e9dd0 to 18b21d7 Compare January 5, 2021 16:34
hanshasselberg
hanshasselberg approved these changes Jan 8, 2021
View reviewed changes
Copy link
Member

@hanshasselberg hanshasselberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crhino crhino merged commit aabdccd into master Jan 8, 2021
@crhino crhino deleted the cpiraino/log-replication-warnings branch January 8, 2021 20:03
@hashicorp-ci
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/307775.

@hashicorp-ci
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/326412.

@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit aabdccd onto release/1.9.x succeeded!

hashicorp-ci pushed a commit that referenced this pull request Feb 10, 2021
@crhino @hashicorp-ci
Log replication warnings when no error suppression is defined (#9320)
db8cc86 
* Log replication warnings when no error suppression is defined

* Add changelog file
@dependabot dependabot bot mentioned this pull request Mar 14, 2021
Closed
dizzyup pushed a commit that referenced this pull request Apr 21, 2021
@crhino @dizzyup
Log replication warnings when no error suppression is defined (#9320)
d802625 
* Log replication warnings when no error suppression is defined

* Add changelog file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanshasselberg hanshasselberg hanshasselberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@crhino @woz5999 @hashicorp-ci @hanshasselberg @rboyer @hashibot-web