ui: Sidebar navigation / redesign #9553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxcode
approved these changes
Jan 12, 2021
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/hashicorp/consul/3kxwgn5zh |
johncowen
force-pushed
the
ui/feature/sidebar-nav
branch
from
76b01b2
to
1bfd24d
Compare
* Add <App /> Component and rearrange <HashcorpConsul /> to use it 1. HashicorpConsul now uses <App /> 2. <App /> is now translated and adds 'skip to main content' functionality 3. Adds ember-in-viewport addon in order to visibly hide main navigation items in order to take them out of focus/tabbing 4. Slight amends to the dom service while I was there * Additional CSS amends for side menus, increased header etc 1. We use dark popover-menus in the side nav 2. Main header is slightly bigger now 3. Undo global themeing but keep component based theming * Remove old ACLs subnav and 're-title-ize' * Fix up pageobjects * Apparently scrolling is a thing, whoops!
johncowen
force-pushed
the
ui/feature/sidebar-nav
branch
from
1bfd24d
to
50ad0f6
Compare
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/317471. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR of another couple/few which re-arrange our main application 'chrome' to use a redesigned sidebar navigation.
This is still currently part way through, but as I've hit a stage with is a working shippable re-design, I thought I'd PR it here and iterate more on it.
The majority of the changes are CSS as the HTML is semantically fine as is (I slightly changed component HTML template to use a tagless component and tweak the order of the toggle button). I'll probably upgrade the component to glimmer completely in the next PR.
There's also a little work here for the basis of a high/low contrast and dark/light mode for better accessibility.