ui: Sidebar navigation / redesign cont. #9582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 18, 2021 12:24
1. HashicorpConsul now uses <App /> 2. <App /> is now translated and adds 'skip to main content' functionality 3. Adds ember-in-viewport addon in order to visibly hide main navigation items in order to take them out of focus/tabbing 4. Slight amends to the dom service while I was there
1. We use dark popover-menus in the side nav 2. Main header is slightly bigger now 3. Undo global themeing but keep component based theming
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/hashicorp/consul/prfejvlxd [Deployment for bd059cd canceled] |
johncowen
added a commit
that referenced
this pull request
Jan 22, 2021
* Add <App /> Component and rearrange <HashcorpConsul /> to use it 1. HashicorpConsul now uses <App /> 2. <App /> is now translated and adds 'skip to main content' functionality 3. Adds ember-in-viewport addon in order to visibly hide main navigation items in order to take them out of focus/tabbing 4. Slight amends to the dom service while I was there * Additional CSS amends for side menus, increased header etc 1. We use dark popover-menus in the side nav 2. Main header is slightly bigger now 3. Undo global themeing but keep component based theming * Remove old ACLs subnav and 're-title-ize' * Fix up pageobjects * Apparently scrolling is a thing, whoops!
johncowen
added a commit
that referenced
this pull request
Jan 26, 2021
* Add <App /> Component and rearrange <HashcorpConsul /> to use it 1. HashicorpConsul now uses <App /> 2. <App /> is now translated and adds 'skip to main content' functionality 3. Adds ember-in-viewport addon in order to visibly hide main navigation items in order to take them out of focus/tabbing 4. Slight amends to the dom service while I was there * Additional CSS amends for side menus, increased header etc 1. We use dark popover-menus in the side nav 2. Main header is slightly bigger now 3. Undo global themeing but keep component based theming * Remove old ACLs subnav and 're-title-ize' * Fix up pageobjects * Apparently scrolling is a thing, whoops!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #9553. The previous PR concentrated on CSS changes in order to implement the new redesign.
This PR is mainly HTML/component changes in order to re-org slightly and add a few new features.
<HashicorpConsul />now uses an<App />component. HashicorpConsul now should only deal with things that are relevant to the ConsulUI. This is purely for the sake of organisation and making things easy to think about/find. Need to change the Consul logo or add a new Consul section (say Auth Methods), look in the HashicorpConsul component as its consul specific. Need to change how the overall navigation works at a general level, that'll be in the App component.color-tonething, and pulled out the CSS related to global theming. But, we still include component level theming. We currently need to support two themes for ourmenu-panels, dark when it is in the side nav, light when it is in the top nav. Thepopover-menusthemselves are made up of different components that take a mix of dark and light theming depending on where they are e.g.All theming is currently controlled in a top level 'themes.scss' file. If it makes sense to split this up at a later date we can.
3. ACLs no longer has a sub navigation so this was removed, the links are no in the SideNav underneath the Access Controls section. We also changed the titles of each of these pages from 'Access Controls' to the name of the section (say Tokens or Roles)
There is potentially a tiny bit of work left to do ontop of this, but I'd really like to get this PR and #9553 merged down to help other ongoing Auth Method work. So if another PR comes it will be post merge based off of
master.