Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Ensure internal/ui/gateway-service-nodes responds with array #9593

Merged
merged 1 commit into from Jan 20, 2021

Conversation

johncowen
Copy link
Contributor

A continuation of #9397 fixes #9535

In some circumstances endpoints that use this function will have no
results in them (due to ACLs, Namespaces, filtering or incorrect/missing
central config registration).

This ensures that the response is at least an empty array ([]) rather
than null.

…ith an array

In some circumstances this endpoint will have no results in it (dues to
ACLs, Namespaces, filtering or missing configuration).

This ensures that the response is at least an empty array (`[]`) rather
than `null`
Copy link
Member

@banks banks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johncowen johncowen merged commit aedd338 into master Jan 20, 2021
@johncowen johncowen deleted the prep-summary-non-null-response branch January 20, 2021 16:59
@hashicorp-ci
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/313313.

johncowen pushed a commit that referenced this pull request Jan 20, 2021
johncowen added a commit that referenced this pull request Jan 20, 2021
hashicorp-ci pushed a commit that referenced this pull request Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property 'filter' of null - ingress gateway UI
3 participants