Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Ensure the internal/ui/service endpoint responds with an array #9397

Merged
merged 1 commit into from Dec 15, 2020

Conversation

johncowen
Copy link
Contributor

In some circumstances this endpoint will have no results in it (due to ACLs, Namespaces or filtering).

This ensures that the HTTP response is at least an empty array ([]) rather than null

In some circumstances this endpoint will have no results in it (dues to
ACLs, Namespaces or filtering).

This ensures that the response is at least an empty array (`[]`) rather
than `null`
@johncowen johncowen added theme/api Relating to the HTTP API interface backport/1.9 labels Dec 15, 2020
@johncowen johncowen requested a review from a team December 15, 2020 12:08
@github-actions github-actions bot removed the theme/api Relating to the HTTP API interface label Dec 15, 2020
@johncowen johncowen added the theme/api Relating to the HTTP API interface label Dec 15, 2020
Copy link
Contributor

@freddygv freddygv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@johncowen johncowen merged commit a9913b5 into master Dec 15, 2020
@johncowen johncowen deleted the service-summary-non-null-response branch December 15, 2020 16:52
@hashicorp-ci
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/298216.

hashicorp-ci pushed a commit that referenced this pull request Dec 15, 2020
…9397)

In some circumstances this endpoint will have no results in it (dues to
ACLs, Namespaces or filtering).

This ensures that the response is at least an empty array (`[]`) rather
than `null`
@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit a9913b5 onto release/1.9.x succeeded!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/api Relating to the HTTP API interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants