Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

agent: remove leading whitespace from agent log lines #10338

Merged
merged 6 commits into from
Jun 3, 2021
Merged

agent: remove leading whitespace from agent log lines #10338

merged 6 commits into from
Jun 3, 2021

Commits on Jun 2, 2021

  1. cmd: remove unnecessary args to agent.New 

    The version args are static and passed in from the caller. Instead read
the static values in New.

The shutdownCh was never closed, so did nothing. Remove it as a field
and an arg.
    @dnephin
    dnephin committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    e573641 View commit details
    Browse the repository at this point in the history

  2. cmd: introduce a shim to expose Stdout/Stderr writers 

    This will allow commands to do the right thing, and write to the proper
output stream.
    @dnephin
    dnephin committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    2fc988d View commit details
    Browse the repository at this point in the history

  3. agent: fix agent logging 

    Remove the leading whitespace on every log line. This was causing problems for
a customer because their logging system was interpretting the logs as a single
multi-line log.
    @dnephin
    dnephin committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    b4b85bd View commit details
    Browse the repository at this point in the history

  4. cmd: move agent running message to logs 

    Previously this line was mixed up with logging, which made the output
quite ugly. Use the logger to output this message, instead of printing
directly to stdout.

This has the advantage that the message will be visible when json logs
are enabled.
    @dnephin
    dnephin committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    2261a46 View commit details
    Browse the repository at this point in the history

  5. cmd: remove unnecessary GatedUi 

    The intent of this struct was to prevent non-json output to stdout. With
the previous cleanup, this can now be done by simply changing the stdout
stream to io.Discard.

This is just one example of why passing around io.Writers for the
streams is better than the UI interface.
    @dnephin
    dnephin committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    cec8bc8 View commit details
    Browse the repository at this point in the history

  6. Add changelog

    @dnephin
    dnephin committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    99956cd View commit details
    Browse the repository at this point in the history