Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connect/ca: cease including the common name field in generated certs #10424

Merged
merged 14 commits into from
Jun 25, 2021
Merged

connect/ca: cease including the common name field in generated certs #10424

merged 14 commits into from
Jun 25, 2021

Commits on Jun 24, 2021

  1. connect/ca: cease including the common name field in generated certs 

    As part of this change, we ensure that the SAN extensions are marked as
critical when the subject is empty so that AWS PCA tolerates the loss of
common names well and continues to function as a Connect CA provider.

Parts of this currently hack around a bug in crypto/x509 and can be
removed after https://go-review.googlesource.com/c/go/+/329129 lands in
a Go release.

Note: the AWS PCA tests do not run automatically, but the following
passed locally for me:

    ENABLE_AWS_PCA_TESTS=1 go test ./agent/connect/ca -run TestAWS
    @rboyer
    rboyer committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    4436254 View commit details
    Browse the repository at this point in the history

  2. changelog

    @rboyer
    rboyer committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    314203d View commit details
    Browse the repository at this point in the history

  3. remove comments

    @rboyer
    rboyer committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    b00369e View commit details
    Browse the repository at this point in the history

  4. remove comment

    @rboyer
    rboyer committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    0a2e2c0 View commit details
    Browse the repository at this point in the history

  5. Update agent/connect/x509_patch.go 

    Co-authored-by: Kent 'picat' Gruber <kent@hashicorp.com>
    @rboyer @picatz
    rboyer and picatz committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    f7a5080 View commit details
    Browse the repository at this point in the history

  6. Update agent/connect/x509_patch.go 

    Co-authored-by: Kent 'picat' Gruber <kent@hashicorp.com>
    @rboyer @picatz
    rboyer and picatz committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    170764d View commit details
    Browse the repository at this point in the history

  7. remove unnecessary clearing of subject field

    @rboyer
    rboyer committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    20e0dd3 View commit details
    Browse the repository at this point in the history

  8. update comment

    @rboyer
    rboyer committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    f38d644 View commit details
    Browse the repository at this point in the history

  9. remove comment

    @rboyer
    rboyer committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    4cc66b7 View commit details
    Browse the repository at this point in the history

  10. remove comment

    @rboyer
    rboyer committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    6afa677 View commit details
    Browse the repository at this point in the history

  11. remove comment

    @rboyer
    rboyer committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    206e1c6 View commit details
    Browse the repository at this point in the history

  12. adding comment

    @rboyer
    rboyer committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    64afccf View commit details
    Browse the repository at this point in the history

  13. reword changelog note

    @rboyer
    rboyer committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    70d2882 View commit details
    Browse the repository at this point in the history

  14. don't need to fix the SAN fields on CA CSRs since they will still hav… 

    …e CN fields
    @rboyer
    rboyer committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    41a20a9 View commit details
    Browse the repository at this point in the history