Revert early out errors in license API #10952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Licensing recently changed in Consul v1.10 and along with those changes the client API was updated such that PutLicense and ResetLicense both immediately return an error to avoid an unecessary round trip to the server that will inevitably fail. Unfortunately, this change broke forward compatibility such that a v1.10 client can no longer make these requests to a v1.9 server which is a valid use case. This commit reintroduces these requests to fix this compatibility breakage but leaves the deprecation notices in tact.
pcewing
force-pushed
the
pcewing-license-api-forward-compatibility
branch
from
8e9eab8
to
f7858e2
Compare
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/438822. |
|
🍒✅ Cherry pick of commit 1a45e96 onto |
hc-github-team-consul-core
pushed a commit
that referenced
this pull request
Aug 31, 2021
Licensing recently changed in Consul v1.10 and along with those changes the client API was updated such that PutLicense and ResetLicense both immediately return an error to avoid an unecessary round trip that will inevitably fail. For reference, see: 08eb600 Unfortunately, this change broke forward compatibility such that a v1.10 client can no longer make these requests to a v1.9 server which is a valid use case. This commit reintroduces these requests to fix this compatibility breakage but leaves the deprecation notices in tact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Licensing recently changed in Consul v1.10 and along with those changes
the client API was updated such that PutLicense and ResetLicense both
immediately return an error to avoid an unecessary round trip that will
inevitably fail.
For reference, see: 08eb600
Unfortunately, this change broke forward compatibility such that a v1.10
client can no longer make these requests to a v1.9 server which is a
valid use case.
This commit reintroduces these requests to fix this compatibility
breakage but leaves the deprecation notices in tact.