Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove step for deleting webhook-cert-manager secret on Consul K8s uninstall #11035

Merged
merged 2 commits into from
Sep 15, 2021

Conversation

david-yu
Copy link
Contributor

As of Consul Helm 0.26.0, for Consul 1.8.x, we no longer need to manually remove the consul-controller-webhook-cert secret. This is a result of hashicorp/consul-k8s#530.

@david-yu david-yu requested a review from a team as a code owner September 15, 2021 04:20
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Sep 15, 2021
@david-yu david-yu added pr/no-changelog PR does not need a corresponding .changelog entry type/docs-cherrypick and removed type/docs Documentation needs to be created/updated/clarified labels Sep 15, 2021
@hashicorp-ci
Copy link
Contributor

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@david-yu david-yu changed the title Remove step for deleting webhook-cert-manager secret docs: Remove step for deleting webhook-cert-manager secret on Consul K8s uninstall Sep 15, 2021
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove the bullet points but this looks good!! Thanks for doing this David!!

Co-authored-by: mrspanishviking <kcardenas@hashicorp.com>
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/444871.

@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit 4e26d94 onto stable-website succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Sep 15, 2021
…K8s uninstall (#11035)

* Remove step for deleting webhook-cert-manager secret
* Update website/content/docs/k8s/operations/uninstall.mdx
@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit 4e26d94 onto release/1.10.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Sep 15, 2021
…K8s uninstall (#11035)

* Remove step for deleting webhook-cert-manager secret
* Update website/content/docs/k8s/operations/uninstall.mdx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants