ui: Improve dev-time SSO/OIDC visibility #11248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
ui/chore/exclude-more-debug
to
ui/feature/test-helpers
October 8, 2021 11:36
johncowen
force-pushed
the
ui/feature/better-oidc-double
branch
from
b1682c6
to
72a452d
Compare
johncowen
force-pushed
the
ui/feature/better-oidc-double
branch
from
72a452d
to
a164567
Compare
johncowen
added
the
pr/no-changelog
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/468426. |
This was referenced Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently had a PR to fix a bug with the UIs OIDC support which we fixed in:
#10901
..and whilst we do have ways to to test this both automatically (to some extent) and manually, it's never been something I've been entirely happy with from an e2e perspective.
This PR tries to make the development experience of working on our OIDC support a little more realistic, essentially by creating our own OIDC provider in our application (only during development builds). You can still provide a real OIDC provider to work with via our dev time environment/cookie variables as before, just now we default to the behaviour in this PR. Overall this makes it much easier to verify our OIDC support in the UI, and also opens up avenues for us to be able to test more scenarios that we couldn't before (for example not only successful logins, but also erroneous, potentially with multiple error reasons).
There are some potential enhancements to our OIDC coming up, so I felt it would be good to get this in in the sense of working on preventative measures rather than curative measures when it comes to working on/improving/changing new features and potential bugs that could come from that.
note the base branch here which includes the work we needed to be able to do this.