Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update raft to v1.3.2 #11375

Merged
merged 3 commits into from
Oct 21, 2021
Merged

update raft to v1.3.2 #11375

merged 3 commits into from
Oct 21, 2021

Conversation

dhiaayachi
Copy link
Collaborator

@dhiaayachi dhiaayachi commented Oct 21, 2021 •
edited

This update raft to v1.3.2 to partially fix #10970

@github-actions github-actions bot added the pr/dependencies PR specifically updates dependencies of project label Oct 21, 2021
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging October 21, 2021 02:10 Inactive
@vercel vercel bot temporarily deployed to Preview – consul October 21, 2021 02:10 Inactive
dnephin
dnephin reviewed Oct 21, 2021
View reviewed changes
.changelog/11375.txt Outdated
@@ -0,0 +1,3 @@
```release-note:enhancement
update raft library to v1.3.2.
Copy link
Contributor

@dnephin dnephin Oct 21, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an enhancement or a bug fix?

I guess the changelog should talk about the issue that was fixed? Something about server leave not triggering an election?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I was not sure if this need to be mentioned in Consul or Raft, But since we don't really ship a changelog with raft we should add it in here.
Also the raft version have other fixes. So I'm not sure how to mention those.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't expect much impact to users for the other changes I think we can omit them. We only really need to include behavioural changes that users may notice.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update the changelog accordingly

@vercel vercel bot temporarily deployed to Preview – consul October 21, 2021 17:00 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging October 21, 2021 17:00 Inactive
@dhiaayachi dhiaayachi merged commit ab31c50 into main Oct 21, 2021
@dhiaayachi dhiaayachi deleted the update_raft_v1.3.2 branch October 21, 2021 17:21
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/481116.

@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit ab31c50 onto release/1.10.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Oct 21, 2021
@dhiaayachi @hc-github-team-consul-core
update raft to v1.3.2 (#11375)
5109c88 
* update raft to v1.3.2

* add changelog

* fix changelog
@blake blake mentioned this pull request Jan 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnephin dnephin dnephin approved these changes

Assignees
No one assigned
Labels
pr/dependencies PR specifically updates dependencies of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consul server leave try to trigger an election
3 participants
@dhiaayachi @hc-github-team-consul-core @dnephin