Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ca: fix storing the leaf signing cert with Vault provider #11671

Merged
merged 3 commits into from Dec 2, 2021
Merged

ca: fix storing the leaf signing cert with Vault provider #11671

merged 3 commits into from Dec 2, 2021

Commits on Nov 30, 2021

  1. ca: add some godoc and func for finding leaf signing cert 

    This will be used in a follow up commit.
    @dnephin
    dnephin committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    32ef9c5 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2021

  1. ca: fix stored CARoot representation with Vault provider 

    We were not adding the local signing cert to the CARoot. This commit
fixes that bug, and also adds support for fixing existing CARoot on
upgrade.

Also update the tests for both primary and secondary to be more strict.
Check the SigningKeyID is correct after initialization and rotation.
    @dnephin
    dnephin committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    b29faa3 View commit details
    Browse the repository at this point in the history

  2. ca: make getLeafSigningCertFromRoot safer 

    As a method on the struct type this would not be safe to call without first checking
c.isIntermediateUsedToSignLeaf.

So for now, move this logic to the CAMananger, so that it is always correct.
    @dnephin
    dnephin committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    28a8a64 View commit details
    Browse the repository at this point in the history