Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ACLMasterToken => ACLInitialManagementToken #11746

Merged
merged 4 commits into from
Dec 7, 2021
Merged

Rename ACLMasterToken => ACLInitialManagementToken #11746

merged 4 commits into from
Dec 7, 2021

Conversation

boxofrad
Copy link
Contributor

@boxofrad boxofrad commented Dec 6, 2021

Following on from #11665 and #11669, this PR renames the ACLMasterToken field to ACLInitialManagementToken, it also fixes the external-facing description of this token.

@boxofrad boxofrad added the pr/no-changelog PR does not need a corresponding .changelog entry label Dec 6, 2021
@github-actions github-actions bot added the theme/config Relating to Consul Agent configuration, including reloading label Dec 6, 2021
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging December 6, 2021 14:36 Inactive
@vercel vercel bot temporarily deployed to Preview – consul December 6, 2021 14:36 Inactive
dnephin
dnephin approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boxofrad boxofrad force-pushed the boxofrad/rename-acl-master-token branch from 17c3e77 to 3535fe1 Compare December 7, 2021 12:15
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging December 7, 2021 12:15 Inactive
@vercel vercel bot temporarily deployed to Preview – consul December 7, 2021 12:15 Inactive
@vercel vercel bot temporarily deployed to Preview – consul December 7, 2021 12:16 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging December 7, 2021 12:16 Inactive
@boxofrad boxofrad merged commit 7fe8117 into main Dec 7, 2021
@boxofrad boxofrad deleted the boxofrad/rename-acl-master-token branch December 7, 2021 12:39
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/519775.

@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/521355.

@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit 7fe8117 onto release/1.11.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Dec 8, 2021
@boxofrad @hc-github-team-consul-core
Rename ACLMasterToken => ACLInitialManagementToken (#11746)
6875c26
@mikemorris mikemorris mentioned this pull request Dec 14, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnephin dnephin dnephin approved these changes

Assignees
No one assigned
Labels
pr/no-changelog PR does not need a corresponding .changelog entry theme/config Relating to Consul Agent configuration, including reloading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@boxofrad @hc-github-team-consul-core @dnephin @rboyer