cli: Fix kv import for keys with trailing slash #11888
Conversation
Correctly import keys names that end in a trailing slash. Fixes #10906
There was a problem hiding this comment.
Thanks for working on this fix! I see it;s still a draft, but I thought I'd have a look.
I have no idea how this should work, but I think we should be explicit about it somewhere. I glanced at https://www.consul.io/commands/kv/import and didn't see much detail about it, but maybe I missed it.
As part of this fix I think we'll need to clearly document how trailing slashes are expected to work for this command. And hopefully we can confirm they work consistently for other commands. I haven't used kv much, so I'm not really sure what other kv commands do with a trailing slash.
|
This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions. |
github-actions
bot
added
the
meta/stale
|
|
github-actions
bot
removed
the
meta/stale
|
This issue was fixed by PR #13939. |
Correctly import keys names that end in a trailing slash.
Fixes #10906