Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ca: change the PrivateKey type/bits validation #12267

Merged
merged 4 commits into from
Feb 4, 2022
Merged

ca: change the PrivateKey type/bits validation #12267

merged 4 commits into from
Feb 4, 2022

Commits on Feb 3, 2022

  1. ca: small cleanup of TestConnectCAConfig_Vault_TriggerRotation_Fails 

    Before adding more test cases
    @dnephin
    dnephin committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    d707173 View commit details
    Browse the repository at this point in the history

  2. ca: relax and move private key type/bit validation for vault 

    This commit makes two changes to the validation.

Previously we would call this validation in GenerateRoot, which happens
both on initialization (when a follower becomes leader), and when a
configuration is updated. We only want to do this validation during
config update so the logic was moved to the UpdateConfiguration
function.

Previously we would compare the config values against the actual cert.
This caused problems when the cert was created manually in Vault (not
created by Consul).  Now we compare the new config against the previous
config. Using a already created CA cert should never error now.

Adding the key bit and types to the config should only error when
the previous values were not the defaults.
    @dnephin
    dnephin committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    608597c View commit details
    Browse the repository at this point in the history

  3. add changelog

    @dnephin
    dnephin committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    81a977c View commit details
    Browse the repository at this point in the history

  4. Make test more readable 

    And fix typo
    @dnephin
    dnephin committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    51b0f82 View commit details
    Browse the repository at this point in the history