Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Update faker to a maintained fork #12538

Closed
wants to merge 3 commits into from
Closed

ui: Update faker to a maintained fork #12538

wants to merge 3 commits into from

Conversation

ST-DDT
Copy link

@ST-DDT ST-DDT commented Mar 8, 2022

The original Faker library is no longer maintained (as you may have heard).
That's why we created a community fork that takes on the further maintenance.
Read more about it here: https://fakerjs.dev/update.html

We have completed the typescript rewrite and now try to update a few dependent projects to ensure we didn't break backwards compatibility.

I don't have a working make setup, so I will use the CI to ensure that this works.

Ref: faker-js/faker#542

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 8, 2022

CLA assistant check
All committers have signed the CLA.

@Amier3
Copy link
Contributor

Amier3 commented Mar 22, 2022

Hey @ST-DDT

Thanks for bringing this to our attention. @johncowen could you take a look at this?

@johncowen johncowen self-assigned this Mar 23, 2022
@johncowen johncowen added the theme/ui Anything related to the UI label Mar 23, 2022
@johncowen
Copy link
Contributor

Hey @ST-DDT 👋

So sorry for the delay here (thanks @Amier3 for the ping!)

I took a quick look and this looks great. Let me check it out and take a proper look though.

FYI: We only use faker in this repository/project for developer tooling, so unless i18n testing is enabled with our developer tooling, it isn't used (and also nothing will be picked up by CI). There is probably another repo I would love to get this updated in also, which would be very exposed to CI, but let me check this one out first and we can go from there.

Also wanted to say, super grateful for what you folks are doing over there in fakerjs-land. Truly amazing. Super flattered you came over here contribute this here 🙇

I'll come back by the end of today hopefully

@johncowen johncowen self-requested a review March 23, 2022 10:03
@github-actions
Copy link

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

@github-actions github-actions bot added the meta/stale Automatically flagged for inactivity by stalebot label May 29, 2022
@github-actions
Copy link

Closing due to inactivity. If you feel this was a mistake or you wish to re-open at any time in the future, please leave a comment and it will be re-surfaced for the maintainers to review.

@github-actions github-actions bot closed this Jun 29, 2022
@ST-DDT ST-DDT deleted the patch-1 branch June 29, 2022 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta/stale Automatically flagged for inactivity by stalebot theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants