[OSS] Add new peering ACL rule #13848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new ACL rule named "peering" to authorize actions taken against peering-related endpoints. The "peering" rule has several key properties: - It is scoped to a partition, and MUST be defined in the default namespace. - Its access level must be "read', "write", or "deny". - Granting an access level will apply to all peerings. This ACL rule cannot be used to selective grant access to some peerings but not others. - If the peering rule is not specified, we fall back to the "operator" rule and then the default ACL rule.
freddygv
requested review from
a team and
mkeeler
and removed request for
a team
freddygv
added
the
pr/no-changelog
mkeeler
approved these changes
Jul 22, 2022
3 tasks
jkirschner-hashicorp
pushed a commit
that referenced
this pull request
Jul 26, 2022
This commit adds a new ACL rule named "peering" to authorize actions taken against peering-related endpoints. The "peering" rule has several key properties: - It is scoped to a partition, and MUST be defined in the default namespace. - Its access level must be "read', "write", or "deny". - Granting an access level will apply to all peerings. This ACL rule cannot be used to selective grant access to some peerings but not others. - If the peering rule is not specified, we fall back to the "operator" rule and then the default ACL rule.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSS Backport of ENT-2281
Description
This commit adds a new ACL rule named "peering" to authorize
actions taken against peering-related endpoints.
The "peering" rule has several key properties:
It is scoped to a partition, and MUST be defined in the default
namespace.
Its access level must be "read', "write", or "deny".
Granting an access level will apply to all peerings. This ACL rule
cannot be used to selective grant access to some peerings but not
others.
If the peering rule is not specified, we fall back to the "operator"
rule and then the default ACL rule.
Testing & Reproduction steps
PR Checklist
external facing docs updatedDeferredTODO for upcoming PR:
Add ACL enforcementAdded in Upgrades to Go 1.7 and fixes vet finding and TLS behavior change. #2281