Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Separate port and socket path validation for local agent into release/1.13.x #14014

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #13906 to be assessed for backporting due to the inclusion of the label backport/1.13.

The below text is copied from the body of the original PR.


Description

PR #12881 Introduced a requirement for either port or socket path to be provided in all requests. Due to a race in automatic port assignment within the agent, automatic assignment needs to be moved from the request-building stage to the locked registration stage post-validation. One solution (this PR) is to exempt the port requirement from request validation when the request is coming from an agent that is trying to do auto-assignment.

Testing & Reproduction steps

  • Manually registering a service from the agent still works with and without a port specified.
  • Existing unit tests seem to cover many cases, and pass without need for changes.

Links

PR #12881
Port assignment issue
Follow-on PR that will need this

PR Checklist

  • updated test coverage
  • [N/A] external facing docs updated
  • [N/A] not a security concern

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/validate-port-agent-split/inherently-many-oriole branch from aff2b40 to 2c1478f Compare August 2, 2022 21:59
@hc-github-team-consul-core hc-github-team-consul-core merged commit 62a3bc4 into release/1.13.x Aug 2, 2022
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/validate-port-agent-split/inherently-many-oriole branch August 2, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants