Backport of validate args before deleting proxy defaults into release/1.13.x #14432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/malizz-validate-name-on-dlt-proxy-defaults/greatly-maximum-bulldog
branch
from
106f864
to
7b5fc53
Compare
hc-github-team-consul-core
deleted the
backport/malizz-validate-name-on-dlt-proxy-defaults/greatly-maximum-bulldog
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #14290 to be assessed for backporting due to the inclusion of the label backport/1.13.
The below text is copied from the body of the original PR.
Description
This PR fixes a bug where proxy defaults could be deleted by any name. Previously the code did not verify the name before proxy config deletion.
Fixes #12684
Testing & Reproduction steps
PR Checklist
Overview of commits