Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes dns.only_passing easier to understand. #14700

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

joshwolfer
Copy link
Contributor

Description

dns.only_passing is challenging to understand as originally worded. Added clarification.

@joshwolfer joshwolfer requested a review from a team as a code owner September 21, 2022 20:44
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Sep 21, 2022
Copy link
Contributor

@trujillo-adam trujillo-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. I made a few suggestions for consistency with our styles

website/content/docs/agent/config/config-files.mdx Outdated Show resolved Hide resolved
Co-authored-by: trujillo-adam <47586768+trujillo-adam@users.noreply.github.com>
@github-actions
Copy link

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

@github-actions github-actions bot added the meta/stale Automatically flagged for inactivity by stalebot label Nov 23, 2022
@github-actions
Copy link

Closing due to inactivity. If you feel this was a mistake or you wish to re-open at any time in the future, please leave a comment and it will be re-surfaced for the maintainers to review.

@github-actions github-actions bot closed this Dec 24, 2022
@jkirschner-hashicorp jkirschner-hashicorp added the meta/staleproof Exempt from stalebot automation label Jan 24, 2023
@jkirschner-hashicorp jkirschner-hashicorp self-assigned this Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta/stale Automatically flagged for inactivity by stalebot meta/staleproof Exempt from stalebot automation pr/no-changelog PR does not need a corresponding .changelog entry pr/no-metrics-test type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants