Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add docs for memberlist metrics #14753

Merged
merged 4 commits into from
Oct 11, 2022
Merged

[Docs] Add docs for memberlist metrics #14753

merged 4 commits into from
Oct 11, 2022

Conversation

jmurret
Copy link
Contributor

@jmurret jmurret commented Sep 26, 2022

Description

The metrics for consul.memberlist.node.instances, consul.memberlist.queue.broadcast, consul.memberlist.size.local, and consul.memberlist.size.remote were added to the memberlist package. Adding documentation for them here.

Links

PR for getting this into 1.14: #14873

@jmurret jmurret added type/docs Documentation needs to be created/updated/clarified pr/no-changelog PR does not need a corresponding .changelog entry pr/no-metrics-test labels Sep 26, 2022
@jmurret jmurret requested a review from a team as a code owner September 26, 2022 18:31
@jmurret jmurret requested a review from rboyer September 26, 2022 18:38
@jmurret jmurret changed the title [Docs} Add metrics for consul.memberlist.node.instances, consul.memberlist.queue.broadcast, consul.memberlist.size.local, and consul.memberlist.size.remote [Docs] Add metrics for consul.memberlist.node.instances, consul.memberlist.queue.broadcast, consul.memberlist.size.local, and consul.memberlist.size.remote Sep 26, 2022
@jmurret jmurret changed the title [Docs] Add metrics for consul.memberlist.node.instances, consul.memberlist.queue.broadcast, consul.memberlist.size.local, and consul.memberlist.size.remote [Docs] Add docs for memberlist metrics Sep 26, 2022
Copy link
Contributor

@trujillo-adam trujillo-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david-yu
Copy link
Contributor

@jmurret Is this for just 1.13 or does this need to be back ported for 1.12. and 1.11?

@jmurret
Copy link
Contributor Author

jmurret commented Oct 4, 2022

@david-yu it is going into 1.14 and no plans for back porting. I updated the description with a link to the PR to update consul with the new serf and memberlist versions.

@david-yu
Copy link
Contributor

david-yu commented Oct 4, 2022

Ah ok got it. Thanks! Btw, one way to overcome the tests failing for a docs PR is to re-name your branch with docs/ prefix so that those tests are skipped. That will re-open the PR though.

@jmurret jmurret merged commit d1f8945 into main Oct 11, 2022
@jmurret jmurret deleted the jm/memberlist-metrics branch October 11, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-changelog PR does not need a corresponding .changelog entry pr/no-metrics-test type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants