fix: missing UDP field in checkType #14885
Conversation
huikang
added
pr/no-changelog
github-actions
bot
added
the
theme/config
|
FYI @dhiaayachi - this is a small follow-up fix on top of #12722 |
There was a problem hiding this comment.
@huikang : I love seeing 1-line PRs that fix an issue with a nice test :) thank you for this.
I'll defer to the engineering team on formally approving.
I feel like this bugfix deserves a changelog entry. Can you add one like this?
```release-note:bug
checks: Fixed a bug that prevented registration of UDP health checks from agent configuration files, such as service definition files with embedded health check definitions.
```
| @@ -1562,6 +1562,7 @@ func (b *builder) checkVal(v *CheckDefinition) *structs.CheckDefinition { | |||
| Body: stringVal(v.Body), | |||
| DisableRedirects: boolVal(v.DisableRedirects), | |||
| TCP: stringVal(v.TCP), | |||
| UDP: stringVal(v.UDP), | |||
There was a problem hiding this comment.
I don't see agent/config/builder.go mentioned in the developer docs that type to capture all the places that need to be checked for health check changes. Can you mention the config builder file? Maybe it can just be included in lines 4 and 5 (which both reference agent/config/config.go, which I think rely on this builder.go file).
There was a problem hiding this comment.
I realize I didn't link to the dev docs I was referencing 🤦
There was a problem hiding this comment.
@jkirschner-hashicorp , thanks. The doc is updated; please take a look.
jkirschner-hashicorp
removed
backport/1.11
backport/1.12
|
Removed backports to 1.11 and 1.12. It seems the UDP health check functionality was first added in 1.13.0, per the changelog: https://github.com/hashicorp/consul/blob/main/CHANGELOG.md#1130-august-9-2022 |
huikang
removed
the
pr/no-changelog
huikang
added
backport/1.14
Description
Fix missing UDP field in builder, when the build parses the service definition file.
Testing & Reproduction steps
Refer to #14864
Links
Fix #14864
PR Checklist