Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Add TCP keepalive settings to proxy config for mesh gateways into release/1.11.x #14998

Merged

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #14800 to be assessed for backporting due to the inclusion of the label backport/1.11.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


This PR adds TCP keepalive settings to the proxy config to be applied to connections between remote mesh gateways. This makes it easier to handle the case of a proxy in between with its own idle timeout settings (like an AWS NLB, which has a non-configurable 350s idle connection timeout).

TODO:

  • Update docs

Overview of commits

@hashicorp-cla
Copy link

hashicorp-cla commented Oct 15, 2022

CLA assistant check
All committers have signed the CLA.

@kyhavlov kyhavlov force-pushed the backport/mgw-tcp-keepalives/surely-fast-oryx branch from 18314c6 to 62e2074 Compare October 15, 2022 02:18
@kyhavlov kyhavlov force-pushed the backport/mgw-tcp-keepalives/surely-fast-oryx branch from 62e2074 to 2f6cb49 Compare October 15, 2022 02:19
@kyhavlov kyhavlov marked this pull request as ready for review October 15, 2022 02:45
@kyhavlov kyhavlov requested a review from a team as a code owner October 15, 2022 02:45
@kyhavlov kyhavlov merged commit 8ca2080 into release/1.11.x Oct 15, 2022
@kyhavlov kyhavlov deleted the backport/mgw-tcp-keepalives/surely-fast-oryx branch October 15, 2022 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants