Get sidecar weights from node service if not specified #15112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
theme/config
mougams
force-pushed
the
connect-weights
branch
from
53b9853
to
dd5bd9f
Compare
boruszak
reviewed
Oct 25, 2022
| @@ -131,6 +131,7 @@ proxy. | |||
| - `port` - Defaults to being auto-assigned from a configurable | |||
| range specified by [`sidecar_min_port`](/docs/agent/config/config-files#sidecar_min_port) | |||
| and [`sidecar_max_port`](/docs/agent/config/config-files#sidecar_max_port). | |||
| - `weights` - Defaults to the parent weights. | |||
There was a problem hiding this comment.
Suggested change
| - `weights` - Defaults to the parent weights. | |
| - `weights` - Defaults to the weights of the parent service. |
Slight variation to the wording to match the phrasing of the other items in the list.
boruszak
approved these changes
Oct 25, 2022
The sidecar service weight was set to default values if not specified by use in connect block of service definition. This patch aims of reusing the node service weights if no weights is specified from connect definition block or if defined to default one.
mougams
force-pushed
the
connect-weights
branch
from
dd5bd9f
to
74c3a81
Compare
|
This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions. |
github-actions
bot
added
the
meta/stale
jkirschner-hashicorp
added
meta/staleproof
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The sidecar service weight was set to default values if not specified by use in connect block of service definition. This patch aims of reusing the node service weights if no weights is specified from connect definition block or if defined to default one.
Testing & Reproduction steps
Test has been updated
Links
This PR is a refresh of #9335
And implements #9334
PR Checklist