connect/ca: clarify error message when tuning Vault mount fails #15293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boxofrad
added
the
pr/no-changelog
github-actions
bot
added
the
theme/connect
boxofrad
force-pushed
the
boxofrad/better-vault-error-logging
branch
from
007bd07
to
802aef1
Compare
|
Should this be backported? |
|
@rboyer Yep! I've added labels for 1.12 through 1.14. Presumably, we're not planning another 1.11 release with 1.14 around the corner? |
|
Looks like this is superseded by #15525 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We recently helped a customer troubleshoot a failed upgrade, where their Connect CA failed to initialize because it encountered a bug in Vault's role validation.
The real problem was obscured by the log message that this PR changes (it wasn't clear what the implications of
tunefailing were) which delayed us finding the bug.