Backport of Detect Vault 1.11+ import in secondary datacenters and update default issuer into release/1.12.x #15681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/fix-vault-ca-secondary-renewal/typically-fresh-grouper
branch
from
cc4a18c
to
88c2628
Compare
hc-github-team-consul-core
force-pushed
the
backport/fix-vault-ca-secondary-renewal/typically-fresh-grouper
branch
from
88c2628
to
cc4a18c
Compare
github-team-consul-core-pr-approver
approved these changes
Dec 5, 2022
github-actions
bot
added
the
theme/connect
… issuer The fix outlined and merged in #15253 fixed the issue as it occurs in the primary DC. There is a similar issue that arises when vault is used as the Connect CA in a secondary datacenter that is fixed by this PR. Additionally: this PR adds support to run the existing suite of vault related integration tests against the last 4 versions of vault (1.9, 1.10, 1.11, 1.12)
rboyer
force-pushed
the
backport/fix-vault-ca-secondary-renewal/typically-fresh-grouper
branch
from
cc4a18c
to
7838b7c
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
rboyer
deleted the
backport/fix-vault-ca-secondary-renewal/typically-fresh-grouper
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #15661 to be assessed for backporting due to the inclusion of the label backport/1.12.
The below text is copied from the body of the original PR.
Description
The fix outlined and merged in #15253 fixed the issue as it occurs in the primary DC. There is a similar issue that arises when vault is used as the Connect CA in a secondary datacenter that is fixed by this PR.
Additionally: this PR adds support to run the existing suite of vault related integration tests against the last 4 versions of vualt (1.9, 1.10, 1.11, 1.12)
Overview of commits