[OSS] feat: access logs for listeners and listener filters #15864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
theme/api
DanStough
changed the title
hashi-derek
approved these changes
Dec 21, 2022
DanStough
force-pushed
the
dans/NET-1753/envoy-access-logs
branch
2 times, most recently
from
f2ea8e1
to
1869cbb
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hashi-derek
reviewed
Dec 22, 2022
DanStough
force-pushed
the
dans/NET-1753/envoy-access-logs
branch
from
1869cbb
to
dbc9f7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the meat of the access logging epic. It adds an Envoy access log configuration to all listeners and listener filters according to the new
proxy-defaultsAPI (#15780 ). Additional notes inline.Testing & Reproduction steps
PR Checklist
external facing docs updatedTBD