Commits on Jun 9, 2023

1. agent: remove agent cache dependency from service mesh leaf certifica… …

   …te management
   
   This extracts the leaf cert management from within the agent cache.
   
   This code was produced by the following process:
   
   1. All tests in agent/cache, agent/cache-types, agent/auto-config,
      agent/consul/servercert were run at each stage.
   
       - The tests in agent matching .*Leaf were run at each stage.
   
       - The tests in agent/leafcert were run at each stage after they
         existed.
   
   2. The former leaf cert Fetch implementation was extracted into a new
      package behind a "fake RPC" endpoint to make it look almost like all
      other cache type internals.
   
   3. The old cache type was shimmed to use the fake RPC endpoint and
      generally cleaned up.
   
   4. I selectively duplicated all of Get/Notify/NotifyCallback/Prepopulate
      from the agent/cache.Cache implementation over into the new package.
      This was renamed as leafcert.Manager.
   
       - Code that was irrelevant to the leaf cert type was deleted
         (inlining blocking=true, refresh=false)
   
   5. Everything that used the leaf cert cache type (including proxycfg
      stuff) was shifted to use the leafcert.Manager instead.
   
   6. agent/cache-types tests were moved and gently replumbed to execute
      as-is against a leafcert.Manager.
   
   7. Inspired by some of the locking changes from derek's branch I split
      the fat lock into N+1 locks.
   
   8. The waiter chan struct{} was eventually replaced with a
      singleflight.Group around cache updates, which was likely the biggest
      net structural change.
   
   9. The awkward two layers or logic produced as a byproduct of marrying
      the agent cache management code with the leaf cert type code was
      slowly coalesced and flattened to remove confusion.
   
   10. The .*Leaf tests from the agent package were copied and made to work
       directly against a leafcert.Manager to increase direct coverage.
   
   I have done a best effort attempt to port the previous leaf-cert cache
   type's tests over in spirit, as well as to take the e2e-ish tests in the
   agent package with Leaf in the test name and copy those into the
   agent/leafcert package to get more direct coverage, rather than coverage
   tangled up in the agent logic.
   
   There is no net-new test coverage, just coverage that was pushed around
   from elsewhere.

   

   rboyer committed Jun 9, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 558a867
   • Browse repository at this point

   Copy the full SHA

   558a867 View commit details

   Browse the repository at this point in the history

2. patch test

   

   rboyer committed Jun 9, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 5cd06e0
   • Browse repository at this point

   Copy the full SHA

   5cd06e0 View commit details

   Browse the repository at this point in the history