Manual backport 1.15.x of Disable remote proxy patching except AWS Lambda #17432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zalimeni
force-pushed
the
backport/zalimeni/net-3900-only-apply-remote-upstream-extension-aws-lambda/1.15.x
branch
from
9ee0655
to
2706524
Compare
github-actions
bot
added
theme/api
zalimeni
force-pushed
the
backport/zalimeni/net-3900-only-apply-remote-upstream-extension-aws-lambda/1.15.x
branch
from
2706524
to
453bdc6
Compare
zalimeni
added
pr/no-changelog
zalimeni
force-pushed
the
backport/zalimeni/net-3900-only-apply-remote-upstream-extension-aws-lambda/1.15.x
branch
from
453bdc6
to
dfbbed3
Compare
zalimeni
requested review from
hashi-derek and
ndhanushkodi
and removed request for
hashi-derek
zalimeni
commented
May 23, 2023
zalimeni
commented
May 23, 2023
zalimeni
force-pushed
the
backport/zalimeni/net-3900-only-apply-remote-upstream-extension-aws-lambda/1.15.x
branch
from
dfbbed3
to
b4dcfc5
Compare
zalimeni
commented
May 23, 2023
Comment on lines
+222
to
+230
| Upstreams: map[api.CompoundServiceName]*extensioncommon.UpstreamData{ | ||
| dbService: { | ||
| SNI: map[string]struct{}{ | ||
| "db.default.dc1.internal.11111111-2222-3333-4444-555555555555.consul": {}, | ||
| }, | ||
| EnvoyID: "db", | ||
| OutgoingProxyKind: "connect-proxy", | ||
| }, | ||
| }, |
There was a problem hiding this comment.
This additional test data existed in main, so I brought it over for a more complete test and parity.
| @@ -0,0 +1,47 @@ | |||
| package extensioncommon | |||
There was a problem hiding this comment.
This file was added after 1.15 as a home for several other helpers that were made exported; I opted to add only the net-new ones from my original PR rather than recreate those migrations (needlessly, since they're defined and used privately in this release branch).
zalimeni
requested review from
erichaberkorn and
cthain
and removed request for
ndhanushkodi
hashi-derek
approved these changes
May 23, 2023
…mbda backport of commit ba18381
zalimeni
force-pushed
the
backport/zalimeni/net-3900-only-apply-remote-upstream-extension-aws-lambda/1.15.x
branch
from
b4dcfc5
to
d2a9daf
Compare
|
Rebased for merge |
zalimeni
deleted the
backport/zalimeni/net-3900-only-apply-remote-upstream-extension-aws-lambda/1.15.x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of commit ba18381
Description
Manual backport of #17415.
Resolves automated backport PR #17428.