Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract some config entry helpers into package #17434

Merged
merged 1 commit into from
May 23, 2023
Merged

extract some config entry helpers into package #17434

merged 1 commit into from
May 23, 2023

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented May 23, 2023

Description

Directly lift a few generic config entry helper functions out of agent/consul into agent/configentry to be used elsewhere later.

@rboyer rboyer added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-metrics-test pr/no-backport labels May 23, 2023
@rboyer rboyer self-assigned this May 23, 2023
@rboyer rboyer merged commit 304d641 into main May 23, 2023
129 checks passed
@rboyer rboyer deleted the extract-configentry-helpers branch May 23, 2023 17:15
nickethier pushed a commit that referenced this pull request May 26, 2023
@rboyer @nickethier
extract some config entry helpers into package (#17434)
293b4ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashi-derek hashi-derek hashi-derek approved these changes

@erichaberkorn erichaberkorn Awaiting requested review from erichaberkorn

Assignees

@rboyer rboyer

Labels
pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry pr/no-metrics-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rboyer @hashi-derek