Backport of Add truncation to body into release/1.15.x #17745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/chappie/CC-5248/lively-settling-ox
branch
2 times, most recently
from
2826269
to
59f90d8
Compare
github-team-consul-core-pr-approver
approved these changes
Jun 14, 2023
chapmanc
approved these changes
Jun 14, 2023
hc-github-team-consul-core
merged commit 9b469bc
into
release/1.15.x
106 of 108 checks passed
hc-github-team-consul-core
deleted the
backport/chappie/CC-5248/lively-settling-ox
branch
chapmanc
added
the
theme/enterprise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17723 to be assessed for backporting due to the inclusion of the label backport/1.15.
The below text is copied from the body of the original PR.
Description
There is a bug in the error logs where the entire body of the request is output. Instead of using the request body in the error we should be using the body of the response and truncating it to a reasonable size and add an ellipsis.
Testing & Reproduction steps
We see this in our error codes with a large payload of metrics (https://go.hashi.co/cc-5248)
Links
DD Link to example of issue: https://go.hashi.co/cc-5248
PR Checklist
Overview of commits