Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Explicitly enable WebSocket upgrades into release/1.14.x #18209

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #18150 to be assessed for backporting due to the inclusion of the label backport/1.14.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@blake
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Description

Explicitly enable WebSocket connection upgrades in Envoy's HTTP connection manager. This is required to enable mesh applications configured with the http protocol to receive WebSocket connection upgrade requests from HTTP clients.

Links

Resolves #8283.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/blake/enable-websocket-connection-upgrades/carefully-faithful-bunny branch from f06f8b8 to 653fe8d Compare July 20, 2023 20:25
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/blake/enable-websocket-connection-upgrades/carefully-faithful-bunny branch 2 times, most recently from 47209f6 to 653fe8d Compare July 20, 2023 20:25
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@github-actions github-actions bot added the theme/envoy/xds Related to Envoy support label Jul 20, 2023
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging July 20, 2023 20:28 Inactive
@vercel vercel bot temporarily deployed to Preview – consul July 20, 2023 20:29 Inactive
@blake blake marked this pull request as ready for review July 20, 2023 21:21
@blake blake merged commit b0f0569 into release/1.14.x Jul 20, 2023
87 checks passed
@blake blake deleted the backport/blake/enable-websocket-connection-upgrades/carefully-faithful-bunny branch July 20, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/envoy/xds Related to Envoy support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants