Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of NET-5382 & PLAT-1159: Do not trigger workflow if only doc files are in commit history into release/1.15.x #18569

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Backport of NET-5382 & PLAT-1159: Do not trigger workflow if only doc files are in commit history into release/1.15.x #18569

merged 1 commit into from
Aug 23, 2023

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #18528 to be assessed for backporting due to the inclusion of the label backport/1.15.

The below text is copied from the body of the original PR.

Description

Stop running go-test and test-integrations workflow if the changes in PR only occurs in docs, ui, website, grafana

  • Add a script to check changeset in branch history
  • If change includes docs + *.go files, trigger test workflows
  • If changes ONLY include docs/, do not trigger test workflows

Testing & Reproduction steps

Testcases

  1. Validate that the following jobs are skipped when changeset only occurs in docs file
    See current CI result
  • go-test
  • test-integrations
Screenshot 2023-08-22 at 4 22 04 PM
  1. Validate that the following jobs are are NOT skipped when changeset occurs in docs and *.go files
  • go-test
  • test-integrations
Screenshot 2023-08-22 at 4 21 04 PM

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern
Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/NET-5382/merely-amazed-mongoose branch from 83a2e72 to 2630934 Compare August 23, 2023 19:26
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/NET-5382/merely-amazed-mongoose branch from 6a089bd to 50bac52 Compare August 23, 2023 19:26
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging August 23, 2023 19:26 Inactive
@github-actions github-actions bot added type/ci Relating to continuous integration (CI) tooling for testing or releases theme/contributing Additions and enhancements to community contributing materials labels Aug 23, 2023
github-team-consul-core-pr-approver
github-team-consul-core-pr-approver approved these changes Aug 23, 2023
View reviewed changes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@vercel vercel bot temporarily deployed to Preview – consul August 23, 2023 19:31 Inactive
@hc-github-team-consul-core hc-github-team-consul-core merged commit 175a5d6 into release/1.15.x Aug 23, 2023
84 of 86 checks passed
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/NET-5382/merely-amazed-mongoose branch August 23, 2023 19:37
@jira jira bot mentioned this pull request Aug 28, 2023
Closed
@jira jira bot mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-team-consul-core-pr-approver github-team-consul-core-pr-approver github-team-consul-core-pr-approver approved these changes

@NiniOak NiniOak Awaiting requested review from NiniOak

Assignees

@NiniOak NiniOak

Labels
theme/contributing Additions and enhancements to community contributing materials type/ci Relating to continuous integration (CI) tooling for testing or releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hc-github-team-consul-core @github-team-consul-core-pr-approver @NiniOak