Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Use Consul Go version for Vault int tests #20219

Merged
merged 1 commit into from
Jan 16, 2024
Merged

ci: Use Consul Go version for Vault int tests #20219

merged 1 commit into from
Jan 16, 2024

Conversation

zalimeni
Copy link
Member

Unlike the Nomad tests (where Nomad is compiled from source and provides the tests), Vault is installed as a binary, and local Consul tests are run.

Fixes incorrect version change introduced in #20058.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@zalimeni
ci: Use Consul Go version for Vault int tests
9816a74 
Unlike the Nomad tests (where Nomad is compiled from source and provides
the tests), Vault is installed as a binary, and local Consul tests are
run.

Fixes incorrect version change introduced in #20058.
@zalimeni zalimeni added backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. backport/1.17 This release series is no longer active on CE. Use backport/ent/1.17. labels Jan 16, 2024
@github-actions github-actions bot added type/ci Relating to continuous integration (CI) tooling for testing or releases theme/contributing Additions and enhancements to community contributing materials labels Jan 16, 2024
@zalimeni zalimeni added the pr/no-changelog PR does not need a corresponding .changelog entry label Jan 16, 2024
curtbushko
curtbushko approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@zalimeni zalimeni enabled auto-merge (squash) January 16, 2024 17:37
@zalimeni zalimeni merged commit a317064 into main Jan 16, 2024
125 of 129 checks passed
@zalimeni zalimeni deleted the zalimeni/use-consul-go-version-vault-int-suite branch January 16, 2024 19:24
This was referenced Jan 16, 2024
Merged
Merged
Merged
@hc-github-team-consul-core
Copy link
Collaborator

@zalimeni, a backport is missing for this PR [20219] for versions [1.15,1.16,1.17] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curtbushko curtbushko curtbushko approved these changes

@wilkermichael wilkermichael Awaiting requested review from wilkermichael

Assignees
No one assigned
Labels
backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. backport/1.17 This release series is no longer active on CE. Use backport/ent/1.17. pr/no-changelog PR does not need a corresponding .changelog entry theme/contributing Additions and enhancements to community contributing materials type/ci Relating to continuous integration (CI) tooling for testing or releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zalimeni @hc-github-team-consul-core @curtbushko