Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: DNS caching tutorial becomes doc #21010

Merged
merged 10 commits into from Apr 24, 2024
Merged

Conversation

boruszak
Copy link
Contributor

@boruszak boruszak commented Apr 23, 2024

Description

This PR converts the previously existing DNS caching tutorial to a documentation page.

Links to this tutorial are broken after the Consul Tutorial Refresh. Given the content of the tutorial, we're electing to move it to documentation.

Deployment preview

The tutorial redirect is in a separate PR: https://github.com/hashicorp/tutorials/pull/2026

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Apr 23, 2024
@boruszak boruszak added pr/no-changelog PR does not need a corresponding .changelog entry backport/1.18 Changes are backported to 1.18 labels Apr 23, 2024
@boruszak boruszak marked this pull request as ready for review April 24, 2024 21:41
@boruszak boruszak requested a review from a team as a code owner April 24, 2024 21:41
Copy link
Contributor

@im2nguyen im2nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving so not blocked!

@boruszak boruszak merged commit e341fa0 into main Apr 24, 2024
61 checks passed
@boruszak boruszak deleted the docs/tutorial-refresh-followup branch April 24, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.18 Changes are backported to 1.18 pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants