Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix two small typos in "What is Consul?" introduction #21110

Merged
merged 1 commit into from
May 15, 2024

Conversation

beckilee
Copy link
Contributor

@beckilee beckilee commented May 15, 2024

Description

This PR fixes #21109. It addresses two small typos in the What is Consul? introductory documentation.

This is my first contribution to Consul, so please let me know if there's anything I need to change. Thanks!

Testing & Reproduction steps

Not applicable

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@beckilee beckilee requested a review from a team as a code owner May 15, 2024 09:01
Copy link

hashicorp-cla-app bot commented May 15, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@blake blake added type/docs Documentation needs to be created/updated/clarified pr/no-changelog PR does not need a corresponding .changelog entry backport/1.18 backport/ent/1.17 Changes are backported to 1.17 ent labels May 15, 2024
Copy link
Member

@blake blake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blake blake enabled auto-merge (squash) May 15, 2024 18:19
@blake blake merged commit 3c24c49 into hashicorp:main May 15, 2024
115 of 120 checks passed
@beckilee beckilee deleted the docs/beckilee/fix-consul-intro-typos branch May 15, 2024 18:42
@hc-github-team-consul-core
Copy link
Collaborator

@beckilee, a backport is missing for this PR [21110] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

1 similar comment
@hc-github-team-consul-core
Copy link
Collaborator

@beckilee, a backport is missing for this PR [21110] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@beckilee
Copy link
Contributor Author

Hi @blake! Sorry to bother you, but the automated comments on this PR say that a backport is missing for version 1.18, even though a backport PR (#21112) was created. Is there something else I need to do on my end? Thanks so much! 🙂

@blake
Copy link
Member

blake commented May 17, 2024

@beckilee Thanks for flagging this. I just merged #21112. The changes should be visible on the website shortly.

absolutelightning added a commit that referenced this pull request May 18, 2024
* Xw/update changelog main (#21108)

* update changelog

* docs: Fix two small typos in "What is Consul?" introduction (#21110)

docs: Fix two typos in Consul introduction

* latest ui files in main (#21119)

* cow

* remove mutexT

* fix compilation

* delete cow

* passing tests

* fixes

* some fixes

* fix delete bug

* fix ret

* fix delete logic

* benchmark tests

* fix data race

* small bench

* no clone

* delete in benchmark

* upgrade deep-copy version, upgrade go to 1.22.3 (#21113)

* upgrade deep-copy version, upgrade go to 1.22.3

* add changelog

* fix memory usages

* some fixes

* fix race

* some optimizations

* fix race

* some optimizations in delete

* some fixes

* fix memory

* fix race

* binary search

* some fixes

* fix race

* some optimizations with type conversion

* removed some type conversions

* removed some more tyep coversion

* benchmarking

* fix lint

* add more data for benchmarks

---------

Co-authored-by: wangxinyi7 <xinyi.wang@hashicorp.com>
Co-authored-by: Becki Lee <becki.lee@gmail.com>
Co-authored-by: John Murret <john.murret@hashicorp.com>
Co-authored-by: Dhia Ayachi <dhia@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.17 Changes are backported to 1.17 ent pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Two small typos in "What is Consul?" introduction
3 participants