Add datacenter to catalog node API #2917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch stores the datacenter of a node in the memdb and exposes it via the API in all places where a Node structure is returned. * /catalog/nodes * /catalog/node/:node * /catalog/service/:service Fixes #2713
kyhavlov
approved these changes
Apr 17, 2017
|
The datacenter will also show up in the /v1/health and /v1/query/<>/execute APIs - can you update the docs and the api client for those as well? It embeds the same node structure. |
slackpad
reviewed
Apr 18, 2017
|
@slackpad I'll do that and add the tests for that as well then. |
slackpad
approved these changes
Apr 18, 2017
|
Squashed and merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch stores the datacenter of a node in the memdb
and exposes it via the API in all places where a Node
structure is returned.
Fixes #2713