-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add datacenter to catalog node API #2917
Conversation
This patch stores the datacenter of a node in the memdb and exposes it via the API in all places where a Node structure is returned. * /catalog/nodes * /catalog/node/:node * /catalog/service/:service Fixes #2713
The datacenter will also show up in the /v1/health and /v1/query/<>/execute APIs - can you update the docs and the api client for those as well? It embeds the same node structure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This same node structure gets sent back in the health and prepared query endpoints, so we should update the API client and docs there too. Otherwise, LGTM!
@slackpad I'll do that and add the tests for that as well then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - if CI looks good it's ready for merge. After that please update the CHANGELOG in a separate commit (you can commit that directly). Looks great!
Squashed and merged to master. |
This patch stores the datacenter of a node in the memdb
and exposes it via the API in all places where a Node
structure is returned.
Fixes #2713