Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support OPTIONS requests #3885

Merged
merged 6 commits into from
Mar 16, 2018
Merged

Support OPTIONS requests #3885

merged 6 commits into from
Mar 16, 2018

Commits on Feb 12, 2018

  1. Support OPTIONS requests 

    - register endpoints with supported methods
- support OPTIONS requests, indicating supported methods
- extract method validation (error 405) from individual endpoints
- on 405 where multiple methods are allowed, create a single Allow
  header with comma-separated values, not multiple Allow headers.
    @eddsteel
    eddsteel committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    77f19f7 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2018

  1. Initialise allowedMethods in init()

    @eddsteel
    eddsteel committed Feb 18, 2018
    Configuration menu
    Copy the full SHA
    f5af8b0 View commit details
    Browse the repository at this point in the history

  2. Allow endpoints to handle OPTIONS/MethodNotFound themselves

    @eddsteel
    eddsteel committed Feb 18, 2018
    Configuration menu
    Copy the full SHA
    c5f0bb3 View commit details
    Browse the repository at this point in the history

  3. Test every endpoint for OPTIONS/MethodNotFound

    @eddsteel
    eddsteel committed Feb 18, 2018
    Configuration menu
    Copy the full SHA
    f770f36 View commit details
    Browse the repository at this point in the history

  4. Clarify comments

    @eddsteel
    eddsteel committed Feb 18, 2018
    Configuration menu
    Copy the full SHA
    d0f0d67 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2018

  1. Re-use defined endpoints for tests

    @eddsteel
    eddsteel committed Mar 3, 2018
    Configuration menu
    Copy the full SHA
    41b1d45 View commit details
    Browse the repository at this point in the history