Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies to pull in large-cluster gossip performance improvements #5189

Merged
merged 1 commit into from
Jan 7, 2019

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented Jan 4, 2019

The bulk of the changes are in hashicorp/memberlist#167 with a minor satellite change in hashicorp/serf#545.

The github.com/hashicorp/go-sockaddr update is related only in that it is a transitive dependency of memberlist that was updated during testing to rectify some go modules plumbing issues.

@rboyer rboyer requested review from armon and a team January 4, 2019 16:39
@pearkes
Copy link
Contributor

pearkes commented Jan 4, 2019

@rboyer I think this still needs the vendorfmt treatment here:

consul/GNUmakefile

Lines 123 to 126 in 067346e

vendorfmt:
@echo "--> Formatting vendor/vendor.json"
test -x $(GOPATH)/bin/vendorfmt || go get -u github.com/magiconair/vendorfmt/cmd/vendorfmt
vendorfmt

That will limit the diff on the vendor file.

This activates large-cluster improvements in the gossip layer from
hashicorp/memberlist#167
@rboyer
Copy link
Member Author

rboyer commented Jan 4, 2019

TIL make vendorfmt

Copy link
Contributor

@pearkes pearkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Target revisions and vendor format look good 👍

@rboyer rboyer merged commit b96391e into master Jan 7, 2019
@rboyer rboyer deleted the faster-bcast-queue branch January 7, 2019 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants